Matrix

This is a continuation of the notation review, using what started as aveverum.rg but is highly mangled now. I've grabbed a random swipe of segments top open in a multi-segment matrix view.

BUG Shift+click on the piano keyboard to select all notes of that pitch. Shift+click and drag to sweep select. Neither of these works. MUST FIX!

BUG Vertical autoscroll while sweep selecting is WAY THE HELL TOO FAST. I think I moved the original report to the “after Thorn” page, but after spending some time with this, it's driving me batshit crazy. It's at least 10 times too fast, not just twice as fast as horizontal. It's insane and unusable. MUST FIX

File Save / Close

Edit

Undo / Redo

Cut / Copy / Paste

Observation Paste does not advance the cursor/pointer. Didn't in Classic either. This makes it very difficult to paste the same string of notes several times in a row, but since classic had the same behavior, I won't flag it as a bug.

Delete

Select All

Filter Selection

Did not test specific behavior (see notation view) but did confirm that applying the last settings used at least changed the selection here, so it's probably hooked up and working a well here as it did in notation.

Preferences

View

Grid

Menu works. Grid combo works.

Toolbars

Rulers

I should test the rulers thoroughly to document selection and resizing problems and other nuisance level glitches we'll probably have to release with. Multi-segment whatzits work swimmingly now thanks to Fryer the Fantabuabulous. That cuts out a huge chunk of worry.

Composition

Add Tempo / Time

Same behavior as notation. I think these just use signals to work exactly the same underlying code, so testing one is probably the same as testing all three. (Also appears in main window.)

Segment

Everything here has equivalents in notation, and appears at a glance to be identical.

Events

Quantize

BUG Events → Quantize and the Q icon should be tied to the have_selection (or whatever it's really called) action state. They *do* work (I assume, did not test beyond looking at the dialog) but they appear broken if you try to use them with no selection, which just fails silently.

Repeat Last Quantize

Damn if I know. I don't know what this is supposed to be useful for, and wouldn't recognize working behavior if I saw it. WTF is this for anyway?

Collapse Equal Pitch Notes

CRASH Well, it was a good run up to now, and it had to happen sooner or later. Hell, CLASSIC would have crashed by now after almost 10 years of development.

Short and sweet one:

Program terminated with signal 11, Segmentation fault.
#0  0x000000000046c80c in std::_Rb_tree<long, std::pair<long const, Rosegarden::TimeSignature>, std::_Select1st<std::pair<long const, Rosegarden::TimeSignature> >, std::less<long>, std::allocator<std::pair<long const, Rosegarden::TimeSignature> > >::clear (this=0x280) at /usr/include/c++/4.4/bits/stl_tree.h:724
724           clear()
(gdb) bt
#0  0x000000000046c80c in std::_Rb_tree<long, std::pair<long const, Rosegarden::TimeSignature>, std::_Select1st<std::pair<long const, Rosegarden::TimeSignature> >, std::less<long>, std::allocator<std::pair<long const, Rosegarden::TimeSignature> > >::clear (this=0x280) at /usr/include/c++/4.4/bits/stl_tree.h:724
#1  0x000000000046c837 in std::_Rb_tree<long, std::pair<long const, Rosegarden::TimeSignature>, std::_Select1st<std::pair<long const, Rosegarden::TimeSignature> >, std::less<long>, std::allocator<std::pair<long const, Rosegarden::TimeSignature> > >::clear (this=0x46c837) at /usr/include/c++/4.4/bits/stl_tree.h:727
#2  0x000000000046b88d in Rosegarden::Event::copyMoving (this=0x4a2942, offset=140736106435904) at src/base/Event.h:157
#3  0x0000000000b34b28 in qt_resource_data ()
#4  0x0000000000000000 in ?? ()

Feature passes a simply constructed test example. Draw a string of 8th notes in notation, open in matrix, collapse equal pitch notes turns them all into one solid event bar. Crash above probably wasn't related.

Increase / Decrease Velocity

BUG (Events → Increase / Decrease Velocity) This makes the velocity toolbar combo go up and down, and a whole lot of debug stream info fly past, but select some events and try to use this, and nothing ever changes. No changes appear on the velocity property ruler either. This seems to be broken.

Set to Current Velocity

Slot exists. Not sure if anything happens, but I suspect it may be related to all the catastrophic brokenness relating to the scene not picking up changes to the segment and reflecting them.

Set Event Velocities

Rescale

All three options work the same as notation

Transpose

BUG Up / Down Semitone and Up / Down Octave and Transpose by Semitones do not function. Transpose by Semitones does pop up a dialog, but it has no effect.

Actually works, but the display don't get updated. -Jani

Trigger Segment / Remove Triggers

Did not test. Sorry. This seems silly here in the matrix anyway.

Pitch Bend Sequence

Did not test beyond making sure the dialog still looks OK.

Move

Cursor Forward / Back and Select

Set Loop to Selection

Works here, unlike notation.

Clear Loop

Next / Previous Segment

Functions.

Transport Controls

Did not test from here.

Tools

Tested the entire menu, including the do-re-mi keys. I don't feel like elaborating. EXCEPT Step recording.

Step Recording

Passes fine. If you reach the end of the segment, you can keep recording and extending the segment, which is probably an accident, but it seems harmless.

 
 
dev/thorn_matrix_review.txt · Last modified: 2022/05/06 16:07 (external edit)
Recent changes RSS feed Creative Commons License Valid XHTML 1.0 Valid CSS Driven by DokuWiki